Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update and rename Rockstar-Games.xml to rockstargames.com.xml - #8263

Closed
Folant wants to merge 5 commits into
EFForg:masterfrom
Folant:rockstargames.com
Closed

Folant wants to merge 5 commits into
EFForg:masterfrom
Folant:rockstargames.com

Conversation

@Folant

@Folant Folant commented Jan 28, 2017

Copy link
Copy Markdown
Contributor

Fix for #8229

@gloomy-ghost

gloomy-ghost commented Jan 31, 2017 •

Copy link
Copy Markdown
Collaborator

Thanks. Please:

Add targets:

  • activate.rockstargames.com
  • lyncdiscover.rockstargames.com
  • m.rockstargames.com
  • mail.rockstargames.com
  • mindlink.rockstargames.com
  • remote.rockstargames.com
  • rsgedi-vpn.rockstargames.com
  • socialclub.rockstargames.com
  • de.socialclub.rockstargames.com
  • es.socialclub.rockstargames.com
  • es-mx.socialclub.rockstargames.com
  • fr.socialclub.rockstargames.com
  • it.socialclub.rockstargames.com
  • ja.socialclub.rockstargames.com
  • ko.socialclub.rockstargames.com
  • pl.socialclub.rockstargames.com
  • pt.socialclub.rockstargames.com
  • ru.socialclub.rockstargames.com
  • zh.socialclub.rockstargames.com

@gloomy-ghost gloomy-ghost self-assigned this Jan 31, 2017
@gloomy-ghost

Copy link
Copy Markdown
Collaborator

Retest


<rule from="^http://(de|es|es-mx|fr|it|ja|ko|pl|pt|ru|zh)\.socialclub\.rockstargames\.com/"
to="https://socialclub.rockstargames.com/" />
<rule from="^http://(de\.|es\.|es-mx\.|fr\.|it\.|ja\.|ko\.|pl\.|pt\.|ru\.|zh\.)?socialclub\.rockstargames\.com/" to="https://socialclub.rockstargames.com/" />

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause looping redirection, can you revert it to 09b231f?

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

Ping @Hainish for the failing Travis CI of 09b231f

@Hainish

Hainish commented Jan 31, 2017

Copy link
Copy Markdown
Member

Strange, let's see if this is a temporary failure. Restarting fetch test.

@Folant Folant mentioned this pull request Mar 13, 2017
@gloomy-ghost

Copy link
Copy Markdown
Collaborator

Retest

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

@Hainish Still

@Hainish

Hainish commented May 18, 2017

Copy link
Copy Markdown
Member

Restarting job again

@Hainish

Hainish commented Jun 7, 2017

Copy link
Copy Markdown
Member

Interesting. For the failing XX.socialclub.rockstargames.com URLs, we're getting a series of redirects that eventually lands on http://socialclub.rockstargames.com. This URL does not respond unless the header Connection: keep-alive is sent in this as well as previous requests. So in modern browsers, the redirect chain works, but not in curl.

@Hainish

Hainish commented Jun 8, 2017

Copy link
Copy Markdown
Member

I'm not sure why remote.rockstargames.com is failing. I'm getting a

user@https-everywhere ~/workspace/https-everywhere (Folant-rockstargames.com) $ curl -LI https://remote.rockstargames.com/
curl: (60) SSL certificate problem: unable to get local issuer certificate

Even when I specify --cacert with the newest cacert.pem from https://curl.haxx.se/ca/cacert.pem, same result:

user@https-everywhere ~/workspace/https-everywhere (Folant-rockstargames.com) $ curl --cacert $(pwd)/cacert.pem -LI https://remote.rockstargames.com/
curl: (60) SSL certificate problem: unable to get local issuer certificate

Regardless, the certificate is valid in all supported browsers.

@Folant Folant closed this Jun 8, 2017
@Folant
Folant deleted the rockstargames.com branch June 8, 2017 06:24
@gloomy-ghost gloomy-ghost removed their assignment Aug 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants